Skip to content

[VEN-1193]: Generic Swapper Contract to Shift Position #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 49 commits into
base: develop
Choose a base branch
from
Open

[VEN-1193]: Generic Swapper Contract to Shift Position #2

wants to merge 49 commits into from

Conversation

@GitGuru7
Copy link
Contributor

@GitGuru7 GitGuru7 commented Jul 30, 2025 •
edited by web3rover
Loading

To run the tests use npm pack to pack the package (VenusProtocol/venus-protocol#606) and then import it in package.json file. Ex: "@venusprotocol/venus-protocol": "file:../venus-protocol/venusprotocol-venus-protocol-9.8.0-dev.19.tgz",

@GitGuru7 GitGuru7 requested a review from chechu July 30, 2025 15:27
@GitGuru7 GitGuru7 self-assigned this Jul 30, 2025
@GitGuru7 GitGuru7 changed the base branch from main to set-up July 30, 2025 15:27
@chechu chechu changed the title [Ven 1193]: Generic swapper contract to shift collateral [VEN 1193]: Generic swapper contract to shift collateral Jul 31, 2025
@chechu chechu changed the title [VEN 1193]: Generic swapper contract to shift collateral [VEN-1193]: Generic swapper contract to shift collateral Jul 31, 2025
@chechu chechu changed the base branch from set-up to develop July 31, 2025 08:56
@chechu chechu force-pushed the feat/VEN-1193 branch 2 times, most recently from 2cffc50 to 9aa16c7 Compare July 31, 2025 09:09
chechu
chechu reviewed Aug 12, 2025
View reviewed changes
chechu
chechu reviewed Aug 12, 2025
View reviewed changes
@web3rover web3rover changed the title [VEN-1193]: Generic swapper contract to shift collateral [VEN-1193]: Generic Swapper Contract to Shift Position Aug 13, 2025
@web3rover web3rover self-assigned this Aug 13, 2025
web3rover and others added 22 commits August 25, 2025 15:10
Debugger022
Debugger022 reviewed Oct 6, 2025
View reviewed changes
Debugger022
Debugger022 reviewed Oct 6, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented Nov 14, 2025

Code Coverage

Package Line Rate Branch Rate Health
contracts 100% 100% ✔
contracts.PositionSwapper 12% 10% ❌
Summary 12% (17 / 137) 10% (12 / 122) ❌

Exef
Exef approved these changes Nov 14, 2025
View reviewed changes
Copy link

@Exef Exef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, since it's already audited and a next version is incoming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@web3rover web3rover web3rover left review comments

@Debugger022 Debugger022 Debugger022 left review comments

@Exef Exef Exef approved these changes

+2 more reviewers

@chechu chechu chechu left review comments

@kkirka kkirka kkirka left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@web3rover web3rover

@GitGuru7 GitGuru7

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@GitGuru7 @chechu @Exef @web3rover @kkirka @Debugger022